fixed Fiery Embrace not working for Scrapper Epic/Patron powersets

[Uun]

Fiery Embrace is coded for all Tanker and Brute Epic/Patron powers. It doesn't appear to be coded for any of the Scrapper Epic/Patron powers.

[Captain Fabulous]

Stalkers don't get it either. I forget the exact reason but IIRC it's by design.

[macskull]

3 minutes ago, Captain Fabulous said:

Stalkers don't get it either. I forget the exact reason but IIRC it's by design.

Stalkers don't get Fiery Embrace at all, so it wouldn't make any sense for them to have the flags on their powers.

 

EDIT: I suppose it sort of makes sense that the Scrapper patron powers don't have the flag since Scrappers and Stalkers share patron power pools - the Scrapper ones aren't a copy of the Stalker ones but instead are literally the exact same powers - but Scrappers have had Fiery Aura since Issue 12 and there's no reason the heroside epic pools shouldn't have the Fiery Embrace flag.

 

Also also, I don't think any pool powers have the flag either.

Edited August 6, 2023 by macskull

[FupDup]

The basic pool powers lack the flag on every AT, even Brutes and Tankers. 

 

This power is a case study in bad programming design. If you have to add a manual tag to individual powers each time, that creates more work for the developers for little benefit. All it takes is one little oversight and you get inconsistencies like this. 

 

The Sentinel version (Molten Embrace) by contrast is designed to be future-proof because it just gives a flat damage bonus to any attack power and also grants the fire proc to them. It never needs to be updated and you don't need to update the pool powers either. This is what good programming looks like. 

 

I think that it would be best in the long run to re-design Fiery Embrace to work more similarly to Molten Embrace, though probably keeping it as a high-impact clicky rather than permanent toggle. 

Edited August 6, 2023 by FupDup

[macskull]

20 minutes ago, FupDup said:

This power is a case study in bad programming design. If you have to add a manual tag to individual powers each time, that creates more work for the developers for little benefit. All it takes is one little oversight and you get inconsistencies like this. 

If you think that's messy you should see how crits, Scourge, Containment, and Domination are handled, especially for pool powers.

 

20 minutes ago, FupDup said:

The Sentinel version (Molten Embrace) by contrast is designed to be future-proof because it just gives a flat damage bonus to any attack power and also grants the fire proc to them. It never needs to be updated and you don't need to update the pool powers either. This is what good programming looks like. 

It's a much more elegant way of doing it, but it's also very limited - Fiery Embrace's bonus damage is affected by enhancements in the source power as well as damage buffs on the character, and can be adjusted on a per-power basis, while Molten Embrace provides a fixed amount of damage determined by the source power's recharge time and areafactor.